feat: check for github scopes #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
force-pushed
the
chore/check-scopes
branch
from
7cb68bc
to
a54f674
Compare
|
A test to validate that it does not allow to disable colors needs to be added, but I need to fix this axios error beforehand |
bmulholland
reviewed
Oct 18, 2023
bmulholland
reviewed
Oct 18, 2023
bmulholland
reviewed
Oct 18, 2023
afonsojramos
force-pushed
the
chore/check-scopes
branch
from
6cbfa9d
to
4757dc5
Compare
bmulholland
reviewed
Dec 6, 2023
bmulholland
reviewed
Dec 6, 2023
bmulholland
reviewed
Dec 6, 2023
bmulholland
approved these changes
Dec 6, 2023
1 task
setchy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #660, also attempting to fix #624, since enabling colors for existing users is breaking notifications for those without the repo scope.
This PR notifies the user every time that he doesn't have the required scopes and disables colors in case he doesn't. Opted by not logging out to not be too annoying.
Warning: Implementation might not be the best.