Python: Add additional sanitizers to SSRF #16657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
changed the title
tausbn
requested changes
Jun 10, 2024
Comment on lines
+158
to
+159
| call = API::moduleImport("re").getMember(["match", "fullmatch"]).getACall() and | ||
| strNode = [call.getArg(1), call.getArgByName("string")] |
There was a problem hiding this comment.
This is great, but I think we should also support the case where the regular expression is compiled in advance. That is
import re
sanitizer_re = re.compile("...")
if sanitizer_re.match(input):
# do stuffUnfortunately, I don't think we expose such a notion in the libraries already (there's compiledRegex in Stdlib.qll, but it's in the internal StdlibPrivate module). However, I think in this case adding a separate case for API::moduleImport("re").getMember("compile").getReturn() (and then the methods you include above) should suffice. (Note that the argument position changes slightly for compiled regexes, so it's not simply a case of augmenting the API::moduleImport("re") bit above.)
tausbn
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/codeql-team/issues/3024
Adds checks against the contents of a string (such as .isalnum; and regex matches) as barrier guards for SSRF.