This repository has been archived by the owner on Feb 5, 2018. It is now read-only.
students_team action
#41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Base class is using ask() from highline/import anyway
|
Should the instructors be added to the team? They currently are not. |
|
Does this need to be more clear? I thought it would be good to output the students who belong to the org's team but were not mentioned in the |
| @@ -113,11 +114,11 @@ def get_team_member_logins(team_id) | |||
| end | |||
|
|
|||
| def read_file(filename, type) | |||
| # Return a hash with team name as key and list of member(s) as value. | |||
There was a problem hiding this comment.
Minor: mind moving this comment one line up, above the method definition?
|
Awesome work! 🤘 Left some nitpicky notes inline. Also, we'll need to
I don't think it would hurt, but I'm fine with the current behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate action for creating a students team of all users named in a
studentsfile.Tests to follow any conversation.