-
Notifications
You must be signed in to change notification settings - Fork 74
add command delete_repos #113
base: master
Are you sure you want to change the base?
add command delete_repos #113
Conversation
4d32c08
to
5c402c9
Compare
) | ||
|
||
request_stubs.each do |request_stub| | ||
expect(request_stub).to have_been_requested.twice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got problem here, I copied and modified this file from lib/teachers_pet/actions/create_repos.rb
.
If I set have_been_requested.
to once, I'll get
Failure/Error: expect(request_stub).to have_been_requested.once The request GET https://testteacher:[email protected]/orgs/testorg/teams?per_page=100 was expected to execute 2 times but it executed 1 time
But if I set it to twice, I'll get
Failure/Error: expect(request_stub).to have_been_requested.once The request GET https://testteacher:[email protected]/orgs/testorg was expected to execute 1 time but it executed 2 times
It's making me crazy 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to at_least_once and it works 😈
5c402c9
to
79c756e
Compare
I'm not sure the test is correct or not, just try to make it pass the CI build, hope somebody can help me audit it, many thanks. |
79c756e
to
81f40b4
Compare
Oops, I found #105 here, I swear that I didn't copy or refer to that PR ... or it won't spent me 2 hours ... 😭 |
Anybody here? @afeld Would you please help me audit this PR? Thank you! |
@PeterDaveHello I removed your comment in the other thread, but I will take a look at this. |
Thanks @johndbritton 😄 |
Thanks for the submission @PeterDaveHello, I took a look and it seems pretty straightforward. @mkcode can you take a closer look and provide some feedback if needed? |
Thanks @johndbritton |
@PeterDaveHello - I added to this PR in #126. Can you please take a look at #126 and create a new PR targeting the |
@mkcode ok I will. |
This command can help me delete the useless or wrong repos, even help me recycle the quota of private repo, hope it can help somebody else.
Never learned and written in ruby before, please correct me if there exist any problem.