Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lowercase roundId on round page & application page #3418

Closed
wants to merge 3 commits into from

Conversation

cristinalare
Copy link
Contributor

@cristinalare cristinalare commented May 7, 2024

Description

bug: if roundId isnt lowercase, round page & application page for allo v1 rounds doesnt load

View here:
https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731/27
https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731

  • convert round id to lowercase on round page & application page

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 7:06am

Copy link

sentry-io bot commented May 7, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/grant-explorer/src/features/round/ViewProjectDetails.tsx

Function Unhandled Issue
ViewProjectDetails TypeError: Cannot read properties of null (reading 'metadata') mapApplicationToProject(features/projects/hooks/u...
Event Count: 8 Affected Users: 11

Did you find this useful? React with a 👍 or 👎

@@ -869,7 +868,7 @@ const RoundStatsTabContent = ({
roundId: string;
round: Round;
chainId: ChainId;
token?: VotingToken;
token?: PayoutToken;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did the type change here?

Copy link
Contributor Author

@cristinalare cristinalare May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because ARBITRUM_TOKENS from votingTokens (which was used before) don't have GTC - see here

so i switched to using payoutTokens

export const payoutTokens = [

let me know if im missing smth/this has any side effects

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types are different and we should consider adding GTC to votingToken. Maybe you can change it back and raise an additional PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! 3e331af

here's the additional PR: #3425

@cristinalare cristinalare mentioned this pull request May 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants