-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lowercase roundId on round page & application page #3418
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: packages/grant-explorer/src/features/round/ViewProjectDetails.tsx
Did you find this useful? React with a 👍 or 👎 |
@@ -869,7 +868,7 @@ const RoundStatsTabContent = ({ | |||
roundId: string; | |||
round: Round; | |||
chainId: ChainId; | |||
token?: VotingToken; | |||
token?: PayoutToken; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did the type change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because ARBITRUM_TOKENS from votingTokens (which was used before) don't have GTC - see here
export const votingTokens = [ |
so i switched to using payoutTokens
export const payoutTokens = [ |
let me know if im missing smth/this has any side effects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types are different and we should consider adding GTC to votingToken. Maybe you can change it back and raise an additional PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
bug: if roundId isnt lowercase, round page & application page for allo v1 rounds doesnt load
View here:
https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731/27
https://explorer.gitcoin.co/#/round/42161/0x5aA255d5CAe9B6cE0F2d9AEE209cB02349B83731
Checklist
This PR:
@ts-ignore
, unjustified optional values).