Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct grants lite #3341

Merged
merged 9 commits into from
May 13, 2024
Merged

Add direct grants lite #3341

merged 9 commits into from
May 13, 2024

Conversation

0xKurt
Copy link
Member

@0xKurt 0xKurt commented Apr 22, 2024

Locally all the changes have been tested on v1 and v2.
Currently, the contract is deployed only on sepolia.

Post fixing the audit changes, we will deploy to all chains and have another PR which disables direct grants round creation on v1 and enables only on v2

We also removed the legacy subgraph calls

Flows Tested:
http://localhost:3000/#/round/116

  • ✅ Created DG on v2
  • ✅ Edit DG on v2
  • ✅ Apply on DG v2
  • ✅ Approve for review on v2
  • ✅ Reject on V2
  • ✅ Approve on V2
  • ✅ Payout on V2
  • ✅ View stat for payout for v2

image

  • ✅ Created DG on v1
  • ✅ Edit Metadata DG on v1
  • Edit Timestamps DG on v1
  • Apply on DG v1
  • Approve for review on v1
  • Reject on V1
  • Approve on V1
  • Payout on V1
  • View stat for payout for v1

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 8:06am

Copy link

sentry-io bot commented Apr 22, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/round-manager/src/features/program/ViewProgramPage.tsx

Function Unhandled Issue
ViewProgram TypeError: nt is null program(context/program/Rea...
Event Count: 1 Affected Users: 19

Did you find this useful? React with a 👍 or 👎

@codenamejason codenamejason linked an issue Apr 22, 2024 that may be closed by this pull request
7 tasks
@meglister
Copy link
Member

DG v1

  • created a round
  • edited a round
  • applied for a round
  • approved applications
  • cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
    Screenshot 2024-05-09 at 2 01 36 PM

@codenamejason
Copy link
Contributor

DG v1

  • created a round
  • edited a round
  • applied for a round
  • approved applications
  • cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
    Screenshot 2024-05-09 at 2 01 36 PM

good catch! we need to prevent the user from removing required questions.

Copy link
Member

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing:

Screenshot 2024-05-09 at 20 26 39
  • the round status badges are behaving strangely

I was able to successfully deploy a round on sepolia, so yay!

@0xKurt
Copy link
Member Author

0xKurt commented May 9, 2024

@melissa-neira
the badges are already off since a while. maybe you want to create a ticket for it with a link/image of how they should look like?

the new strategy is currently not deployed to arbitrum, only sepolia

@0xKurt
Copy link
Member Author

0xKurt commented May 9, 2024

DG v1

  • created a round
  • edited a round
  • applied for a round
  • approved applications
  • cannot pay out applications -- see screenshot and error attached. I have a blank screen that loads
    Screenshot 2024-05-09 at 2 01 36 PM

i faced this one today: #3424
which is kinda related to your problem with the removed token.

i have an idea on how to solve it and add the new feature with the token list. maybe we can talk about it next week really quick

@meglister
Copy link
Member

meglister commented May 9, 2024

DG v2

  • created round
  • edited round
  • applied to round
  • I marked an application as in review from the application page in manager. The tx succeeded, but it was not reflected in the UI. Here's the tx: https://sepolia.etherscan.io/tx/0x66509ef35737d7d5973f81750f490347c82c08d33056cce741253524dda6720a
    Screenshot of UI behind processing modal -- I tried again to approve from the Grant Applications page and after the page refresh the new status was reflected. Maybe we need to force a page refresh or something.
    Screenshot 2024-05-09 at 2 51 32 PM
  • approved applications
  • paid out applications -- not working because of same error as above with removing payout token field
    Screenshot 2024-05-09 at 2 53 58 PM
  • view applications in explorer -- open end dates are not working as expected
    Screenshot 2024-05-09 at 2 48 55 PM

@codenamejason
Copy link
Contributor

small thing:

Screenshot 2024-05-09 at 20 26 39 * the round status badges are behaving strangely

I was able to successfully deploy a round on sepolia, so yay!

The was done to accomidate the 'applications not started' badge, we can revisit how to render the badges in a nice consistent way.

@0xKurt
Copy link
Member Author

0xKurt commented May 10, 2024

@meglister
The issue with the explorer timestamps appears because if you click the link you open the explorer in production and not staging.

Onq staging it's already fixed https://explorer-staging-git-add-direct-grants-lite-grants-stack.vercel.app/#/round/11155111/139

paid-out applications -- not working because of same error as above with removing payout token field

This is an existing bug and we will fix it in a follow up PR

@thelostone-mc thelostone-mc merged commit d44273e into main May 13, 2024
14 checks passed
@thelostone-mc thelostone-mc deleted the add-direct-grants-lite branch May 13, 2024 08:14
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
* feat: add direct grants v2

Author:    0xKurt <[email protected]>

fix: donations/when application is null (gitcoinco#3411)

* fix: donations/when application is null

* remove log

updated url

update env

fix tests

remove react() plugin

fix placeholder error

* changed v1/v2 switch

* regenerate lock

* temp update switch for dg v2

* fix

* rm log

* recipientsCounter

* fix bug

* fix

---------

Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: Jaxcoder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

GS Direct Grants
6 participants