-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: fix round settings responsive layout #2756
style: fix round settings responsive layout #2756
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is 50% new code. |
@melissa-neira I did not change with that part of the page, but will fix. Are there any other discrepancies on the page that I can fix, while I'm at it? |
@vacekj nope, just that for now! thank you |
…n-fund-grantees-tab-paid-grantees
🥷 Code experts: bhargavaparoksham bhargavaparoksham, vacekj have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vacekj great work! Wanted to callout that the UI issue Melissa called out is still happening on the Paid Grantees tab (fixed on the Unpaid Grantees tab):
See this round: https://manager-git-2398-manager-page-layout-is-not-12e67f-grants-stack.vercel.app/#/round/0xfaf72df9d5384bdb0e56901bf770c27d28af084d
However, I wouldn't say this is a blocking issue, so I've approved the PR. Feel free to fix if you have time/bandwidth!
* style: fix round settings responsive layout * style: remove unnecessary padding in fund grantees tab
* style: fix round settings responsive layout * style: remove unnecessary padding in fund grantees tab
Fixes: #2398
Description
fixes responsive layout in manager round settings screen
Checklist
This PR:
@ts-ignore
, unjustified optional values).