Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix round settings responsive layout #2756

Conversation

vacekj
Copy link
Contributor

@vacekj vacekj commented Dec 21, 2023

Fixes: #2398

Description

fixes responsive layout in manager round settings screen

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vacekj vacekj requested review from a team as code owners December 21, 2023 12:46
Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:18pm

Copy link

gitstream-cm bot commented Dec 21, 2023

This PR is 50% new code.

@melissa-neira
Copy link
Member

Screenshot 2023-12-21 at 08 49 41 the text under the fund grantees tab should be aligned with that margin. right now it looks like there's some unnecessary padding there

@vacekj
Copy link
Contributor Author

vacekj commented Dec 21, 2023

@melissa-neira I did not change with that part of the page, but will fix. Are there any other discrepancies on the page that I can fix, while I'm at it?

@melissa-neira
Copy link
Member

@vacekj nope, just that for now! thank you

Copy link

gitstream-cm bot commented Jan 2, 2024

🥷 Code experts: bhargavaparoksham

bhargavaparoksham, vacekj have most 👩‍💻 activity in the files.
bhargavaparoksham, vacekj have most 🧠 knowledge in the files.

See details

packages/round-manager/src/features/round/ViewFundGrantees.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
JAN
DEC 2 additions & 1 deletions
NOV 0 additions & 3 deletions
OCT 47 additions & 48 deletions
SEP
AUG

Knowledge based on git-blame:
vacekj: 16%
bhargavaparoksham: 5%

packages/round-manager/src/features/round/ViewRoundPage.tsx

Activity based on git-commit:

bhargavaparoksham vacekj
JAN
DEC
NOV
OCT 315 additions & 205 deletions
SEP
AUG

Knowledge based on git-blame:
bhargavaparoksham: 69%
vacekj: 7%

To learn more about /:\ gitStream - Visit our Docs

Copy link
Contributor

@michellema1208 michellema1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vacekj great work! Wanted to callout that the UI issue Melissa called out is still happening on the Paid Grantees tab (fixed on the Unpaid Grantees tab):

Screen Shot 2024-01-02 at 4 32 24 PM

See this round: https://manager-git-2398-manager-page-layout-is-not-12e67f-grants-stack.vercel.app/#/round/0xfaf72df9d5384bdb0e56901bf770c27d28af084d

However, I wouldn't say this is a blocking issue, so I've approved the PR. Feel free to fix if you have time/bandwidth!

@vacekj vacekj merged commit b92b5d5 into main Jan 3, 2024
20 checks passed
@vacekj vacekj deleted the 2398-manager-page-layout-is-not-responsive-on-fund-grantees-tab-paid-grantees branch January 3, 2024 12:12
xinbianjiang20 pushed a commit to xinbianjiang20/grants-stack that referenced this pull request Jan 6, 2024
* style: fix round settings responsive layout

* style: remove unnecessary padding in fund grantees tab
xinbianjiang20 pushed a commit to xinbianjiang20/grants-stack that referenced this pull request Jan 6, 2024
* style: fix round settings responsive layout

* style: remove unnecessary padding in fund grantees tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager: page layout is not responsive on Fund Grantees tab > Paid Grantees
4 participants