restore send transaction type safety (#2840)

gitcoinco · Jan 29, 2024 · 7da8306 · 7da8306
1 parent 3e01054
commit 7da8306
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/common/src/allo/backends/allo-v1.ts b/packages/common/src/allo/backends/allo-v1.ts
@@ -1,4 +1,4 @@
-import { Address, Hex } from "viem";
+import { Address, Hex, hexToBigInt } from "viem";
 import { Allo, AlloError, AlloOperation } from "../allo";
 import {
   TransactionReceipt,
@@ -137,12 +137,14 @@ export class AlloV1 implements Allo {
         return ipfsResult;
       }
 
+      const projectIndex = hexToBigInt(args.projectId);
+
       // --- send transaction to update project metadata
       const txResult = await sendTransaction(this.transactionSender, {
         address: this.projectRegistryAddress,
         abi: ProjectRegistryABI,
         functionName: "updateProjectMetadata",
-        args: [args.projectId, { protocol: 1n, pointer: ipfsResult.value }],
+        args: [projectIndex, { protocol: 1n, pointer: ipfsResult.value }],
       });
 
       emit("transaction", txResult);

diff --git a/packages/common/src/allo/transaction-sender.ts b/packages/common/src/allo/transaction-sender.ts
@@ -235,9 +235,12 @@ export async function sendRawTransaction(
   }
 }
 
-export async function sendTransaction(
+export async function sendTransaction<
+  TAbi extends Abi,
+  TFunctionName extends string,
+>(
   sender: TransactionSender,
-  args: Parameters<typeof encodeFunctionData>[0] & { address: Address }
+  args: EncodeFunctionDataParameters<TAbi, TFunctionName> & { address: Address }
 ): Promise<Result<Hex>> {
   try {
     const data = encodeFunctionData(args);