Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump git2-hooks #4999

Merged
merged 1 commit into from
Sep 30, 2024
Merged

chore: Bump git2-hooks #4999

merged 1 commit into from
Sep 30, 2024

Conversation

icorbrey
Copy link
Contributor

☕️ Reasoning

I fixed an upstream issue in git2-hooks where executing Git hooks would cause extra windows to spawn on Windows. This PR makes GitButler use those changes.

🧢 Changes

  • Bump git2-hooks to version 0.4.

🎫 Affected issues

Fixes: #4982

Copy link

vercel bot commented Sep 30, 2024

@icorbrey is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Sep 30, 2024
@krlvi
Copy link
Member

krlvi commented Sep 30, 2024

Nice, and thank you so much for the upstream fix! lets get this in if the tests are happy

@icorbrey
Copy link
Contributor Author

No problem at all, it's honestly nothing more than a cosmetic issue but it irritated me enough that I just had to fix it. Hopefully this helps with the general Git hooks effort!

@krlvi krlvi merged commit 3742349 into gitbutlerapp:master Sep 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeftHook commit-msg hooks spawn visible shells before executing
2 participants