chore(db): Améliorer l'hydratation de la base de données en developpement #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
added
the
hot fix
There was a problem hiding this comment.
La magie qui me semblerait intéressante serait de vérifier que le venv est bien actif et à jour (et le construire ou l’activer si besoin). C’est l’histoire de la dépendance $(VIRTUAL_ENV) sur le C1. Fais-moi signe si tu es intéressé pour une explication de cette magie noire (et imparfaite) :)
| dropdb --if-exists $(POSTGRESQL_ADDON_DB) | ||
| createdb $(POSTGRESQL_ADDON_DB) | ||
| python manage.py migrate | ||
| python manage.py configure_bucket |
There was a problem hiding this comment.
Pinaillage, mais ce n’est pas de la DB, c’est pour minio.
Une fois que c’est fait, normalement pas besoin de le refaire.
Comment on lines
-26
to
-35
| docker exec -ti commu_postgres dropdb $POSTGRESQL_ADDON_DB -U $POSTGRESQL_ADDON_USER --if-exists --echo | ||
| dropdb $POSTGRESQL_ADDON_DB -U $POSTGRESQL_ADDON_USER --if-exists --echo | ||
|
|
||
| echo "creating new db" | ||
| docker exec -ti commu_postgres createdb $POSTGRESQL_ADDON_DB -O $POSTGRESQL_ADDON_USER -U $POSTGRESQL_ADDON_USER --echo | ||
| createdb $POSTGRESQL_ADDON_DB -O $POSTGRESQL_ADDON_USER -U $POSTGRESQL_ADDON_USER --echo | ||
|
|
||
| echo "restoring db" | ||
| docker exec -ti commu_postgres pg_restore -U $POSTGRESQL_ADDON_USER --dbname=$POSTGRESQL_ADDON_DB --format=c --clean --no-owner --verbose /backups/$DB_BACKUP_NAME | ||
| pg_restore -U $POSTGRESQL_ADDON_USER --dbname=$POSTGRESQL_ADDON_DB --format=c --clean --no-owner $DB_BACKUP_PATH | ||
|
|
||
| echo "restarting db" | ||
| docker-compose down postgres; docker-compose up postgres -d |
There was a problem hiding this comment.
Ces changements font que le dev doit avoir installé le client PostgreSQL sur sa machine. Pas bien grave, mais peut-être l’ajouter dans le README ?
vincentporte
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Ajout de la commande
resetdbdans le fichierMakefilepour automatiser l'hydratation d'une DB de dev🎸 Amélioration du script de restauration des dump de DB : suppression surcouche
docker, ajout des migrationsType de changement
🚧 technique