-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forum): utiliser l'image du forum dans la vignette opengraph #725
Merged
vincentporte
merged 1 commit into
master
from
722-seo-opengraph-image-des-pages-de-forums
Jul 31, 2024
Merged
feat(forum): utiliser l'image du forum dans la vignette opengraph #725
vincentporte
merged 1 commit into
master
from
722-seo-opengraph-image-des-pages-de-forums
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orsque le forum possède sa propre image
vincentporte
changed the title
feat(forum): utiliser l'image du forum dans les vignettes opengraph
feat(forum): utiliser l'image du forum dans la vignette opengraph
Jul 30, 2024
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
calummackervoy
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple, efficace :)
hellodeloo
approved these changes
Jul 31, 2024
vincentporte
added a commit
that referenced
this pull request
Aug 1, 2024
vincentporte
pushed a commit
that referenced
this pull request
Aug 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.12.0](v2.11.0...v2.12.0) (2024-08-07) ### Features * **documentation:** rendre la certification optionnelle ([#741](#741)) ([6141112](6141112)) * **footer:** mise à jour des liens sociaux ([#730](#730)) ([f19602e](f19602e)) * **forum:** attr accept définit sur forms.ImageField ([#734](#734)) ([0e8b8c9](0e8b8c9)) * **forum:** fin de l'AB test sur la notation des forums ([#708](#708)) ([6705ead](6705ead)) * **forum:** utiliser l'image du forum dans la vignette opengraph ([#725](#725)) ([cc137c1](cc137c1)) * mise à jour entête, pied de page et menu ([#739](#739)) ([4493267](4493267)) * **notification:** passage des notifications en lues ([#712](#712)) ([a1a6b73](a1a6b73)) * **seo:** mise à jour de l'image OpenGraph ([#720](#720)) ([f37521c](f37521c)) ### Bug Fixes * **forum:** balise `article` et dimension des images ([#737](#737)) ([b1ed91f](b1ed91f)) * mise à jour de la public key sentry pour l'envoi des logs ([#732](#732)) ([616c0aa](616c0aa)) * **upvotes:** largeur du bouton s'abonner dynamique ([#743](#743)) ([32cb339](32cb339)) * **upvote:** supprimer un parametrage ambigue ([#742](#742)) ([168df13](168df13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Lorsqu'une image est définie pour un
forum
, alimenter la vignette opengraph avec, au lieu de l'image par défautType de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🎨 changement d'UI
Points d'attention
🦺 images privées stockées dans un bucket
capture d'écran
Vue des
forum
d'une catégorieVue d'un
forum
vignette du
forum
lors du partage