Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCUMENTATION] poser une question en haut de doc #464

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

vincentporte
Copy link
Contributor

Description

🎸 rendre visible la possibilité de poser une question sur une fiche technique

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🎨 UI

Captures d'écran (optionnel)

image

@hellodeloo
Copy link
Contributor

@vincentporte Un petit commit pour un petit correctif de mise en forme.

Par contre, je m'interroge sur le fait de "doubloner" le bouton. Un dans la sidebar et un apres le contenu.
Perso, j'aurais bien viré celui en dessous du contenu et garder seulement celui de la sidebar en prenant soin de réintégrer la condition {% if forum.kind == 'NEWS' %}{% trans "New news" %}{% else %}{% trans "New topic on doc" %}{% endif %}

@vincentporte vincentporte force-pushed the vincentporte/new_post_button_on_docs branch from 5e9d03a to a1ac64b Compare November 28, 2023 11:22
@vincentporte vincentporte merged commit 4177b32 into master Nov 28, 2023
4 checks passed
@vincentporte vincentporte deleted the vincentporte/new_post_button_on_docs branch November 28, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants