Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMAGES] déposer des images publiques #388

Merged

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Sep 4, 2023

Description

🎸 téléverser des images publiques pour les utiliser dans le markdown de la documentation
🎸 accèder à ces images avec une url permanente
🎸 prevenir le televersement de fichiers volumineux (> 8MB ~ 1 Mo)
🎸 prevenir le televersement de fichiers autre que des images

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).

Points d'attention

🦺 Fonctionne avec bucket associé = KO en dev avec le backend FileSystemStorage. Point assumé pour ne pas surcharger le code. Cette feature est un "addon" spécifique pour les staffs/superuser. Pas de généralisation prévue à court-terme
🦺 Accès via l'admin uniquement

@vincentporte vincentporte self-assigned this Sep 4, 2023
@vincentporte vincentporte linked an issue Sep 4, 2023 that may be closed by this pull request
@vincentporte vincentporte added the python Pull requests that update Python code label Sep 4, 2023
@vincentporte vincentporte force-pushed the 375-deposer-des-images-pour-les-fiches-techniques branch from bef949a to 37a84d0 Compare September 4, 2023 14:30
@vincentporte vincentporte marked this pull request as ready for review September 4, 2023 14:36
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valider que le fichier est bien une image (l’ouvrir avec Pillow) me semble judicieux. Après, comme seuls des superusers auront la possibilité de le faire, à toi de voir si c’est utile.

lacommunaute/forum_file/models.py Outdated Show resolved Hide resolved
config/settings/dev.py Outdated Show resolved Hide resolved
@vincentporte vincentporte force-pushed the 375-deposer-des-images-pour-les-fiches-techniques branch from 157813f to 9bf9aa8 Compare September 5, 2023 05:30
@vincentporte vincentporte merged commit 74e69de into master Sep 5, 2023
4 checks passed
@vincentporte vincentporte deleted the 375-deposer-des-images-pour-les-fiches-techniques branch September 5, 2023 05:39
@sentry-io
Copy link

sentry-io bot commented Sep 5, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NoSuchBucket: An error occurred (NoSuchBucket) when calling the PutObject operation: Unknown /admin/forum_file/publicfile/add/ View Issue

Did you find this useful? React with a 👍 or 👎

@vincentporte
Copy link
Contributor Author

issue solved

@vincentporte vincentporte mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCUMENTATION] Deposer des images pour les fiches techniques
3 participants