Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPVOTE] sauvegarder un forum #362

Merged
merged 7 commits into from
Jul 26, 2023
Merged

[UPVOTE] sauvegarder un forum #362

merged 7 commits into from
Jul 26, 2023

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented Jul 24, 2023 •
edited
Loading

Description

🎸 Sauvegarder un Forum depuis la vue de détail de ce forum.
⚠️ actuellement limité aux forums enfants de forums de type catégorie

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).

Points d'attention

🦺 suite des PR #354 et #356
🦺 consolidation de PostUpVoteView et ForumUpVoteView avec le mixin BaseUpVoteView
🦺 passage des params obj et kind au template upvotes.html pour gérer les différents modèles à lier
🦺 renommage de l'url forum_upvote:post pour désambiguer les routes

Captures d'écran (optionnel)

vue de détail d'un forum enfant d'un forum de type catégorie

image.

upvote des messages

image

@vincentporte vincentporte added the python Pull requests that update Python code label Jul 24, 2023
@vincentporte vincentporte self-assigned this Jul 24, 2023
@vincentporte vincentporte linked an issue Jul 24, 2023 that may be closed by this pull request
[FORUM] sauvegarder un forum #361
Closed
2 tasks
@vincentporte vincentporte marked this pull request as ready for review July 24, 2023 16:19
@vincentporte vincentporte changed the base branch from master to 351-forum-upvote July 24, 2023 16:26
@vincentporte vincentporte force-pushed the 361-forum-sauvegarder-un-forum branch from 53612f7 to e132027 Compare July 24, 2023 16:27
@vincentporte vincentporte force-pushed the 351-forum-upvote branch 2 times, most recently from 838986f to 96bb1b9 Compare July 25, 2023 09:32
@vincentporte vincentporte force-pushed the 361-forum-sauvegarder-un-forum branch from e132027 to ba4ebb1 Compare July 25, 2023 09:41
Base automatically changed from 351-forum-upvote to master July 25, 2023 10:26
@vincentporte vincentporte force-pushed the 361-forum-sauvegarder-un-forum branch from ba4ebb1 to b81bb87 Compare July 25, 2023 10:26
francoisfreitag
francoisfreitag approved these changes Jul 26, 2023
View reviewed changes
lacommunaute/forum/models.py Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/views.py Outdated Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Outdated Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Outdated Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Show resolved Hide resolved
lacommunaute/forum_upvote/views.py Outdated Show resolved Hide resolved
lacommunaute/templates/partials/upvotes.html Show resolved Hide resolved
@vincentporte vincentporte force-pushed the 361-forum-sauvegarder-un-forum branch from b81bb87 to 9177935 Compare July 26, 2023 10:08
vincentporte
vincentporte commented Jul 26, 2023
View reviewed changes
Copy link
Contributor Author

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @francoisfreitag

lacommunaute/forum/models.py Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Outdated Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Show resolved Hide resolved
lacommunaute/forum_upvote/tests/test_forumupvoteview.py Show resolved Hide resolved
lacommunaute/forum_upvote/views.py Outdated Show resolved Hide resolved
lacommunaute/templates/partials/upvotes.html Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
@vincentporte vincentporte force-pushed the 361-forum-sauvegarder-un-forum branch from 9177935 to 398c511 Compare July 26, 2023 15:33
@vincentporte vincentporte merged commit 9e845cb into master Jul 26, 2023
4 checks passed
@vincentporte vincentporte deleted the 361-forum-sauvegarder-un-forum branch July 26, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisfreitag francoisfreitag francoisfreitag approved these changes

Assignees

@vincentporte vincentporte

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FORUM] sauvegarder un forum
2 participants
@vincentporte @francoisfreitag