Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Label financement #439

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Label financement #439

merged 7 commits into from
Sep 3, 2024

Conversation

ggounot
Copy link
Collaborator

@ggounot ggounot commented Aug 20, 2024

Cette implémentation est purement front-end car c'est une expérimentation.

@ggounot
Copy link
Collaborator Author

ggounot commented Aug 20, 2024

ikarius
ikarius previously approved these changes Aug 23, 2024
Copy link
Contributor

@ikarius ikarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Ça me semble très bien.
Je comprends le coté front-end seulement pour l'expérimentation, mais il faudra surement voir comment stocker ces données ailleurs par la suite ... ou pas.

@ggounot
Copy link
Collaborator Author

ggounot commented Aug 26, 2024

LGTM Ça me semble très bien. Je comprends le coté front-end seulement pour l'expérimentation, mais il faudra surement voir comment stocker ces données ailleurs par la suite ... ou pas.

Il y a un début de travail sur le stockage ici : gip-inclusion/dora-back#355 À continuer après la phase d'expérimentation.

@ggounot ggounot requested a review from jbuget August 26, 2024 14:01
jbuget
jbuget previously approved these changes Aug 28, 2024
Copy link
Contributor

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Nous avons effectué le test sur ma machine sur la branche ensemble avec @ggounot

src/routes/recherche/+page.svelte Outdated Show resolved Hide resolved
@ggounot ggounot requested a review from jbuget August 28, 2024 09:57
Copy link
Contributor

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

src/routes/recherche/result-filters.svelte Show resolved Hide resolved
@ggounot ggounot merged commit 8465b28 into main Sep 3, 2024
7 checks passed
@ggounot ggounot deleted the label-financement branch September 3, 2024 09:07
jbuget pushed a commit that referenced this pull request Sep 3, 2024
Cette implémentation est purement front-end car c'est une
expérimentation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants