Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grist as a source #95

Closed
wants to merge 10 commits into from
Closed

feat: grist as a source #95

wants to merge 10 commits into from

Conversation

vmttn
Copy link
Contributor

@vmttn vmttn commented May 23, 2023

  • notebook pour créer facilement des documents sur grist qui respecte le format attendu par l'extraction
  • y ajouter la création d'une table avec les typologies de structures
  • client grist
  • extraction des données
  • activer éventuellement l'extraction des services dans les settings

Remarque: l'api grist n'est pas top. Plusieurs problèmes:

  • impossible de supprimer des tables
  • pas de création idempotente (e.g. PUT)
  • contrairement aux autres ressources (workspace, document), les tables sont identifiées à partir du nom fourni et "normalisé" (pas documenté). Le nom de la table n'est pas disponible sur l'api, ce qui est problématique pour la retrouver si le nom ne correspond plus à l'identifiant. Il faut s'assurer que la table a été créé avec un identifiant bien défini (d'où le template).

@gitguardian
Copy link

gitguardian bot commented May 23, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vmttn
Copy link
Contributor Author

vmttn commented May 23, 2023

~ 5min entre token mis en ligne et sa désactivation

@vmttn vmttn force-pushed the vmttn/feat/extract-grist branch from 7e7655b to 69cae4c Compare May 23, 2023 08:32
@vmttn vmttn force-pushed the vmttn/feat/extract-grist branch from 24b7345 to d96b2b4 Compare May 23, 2023 14:37
@vmttn
Copy link
Contributor Author

vmttn commented Jun 1, 2023

related to #93

@vmttn vmttn requested a review from ColinMaudry June 1, 2023 09:01
Copy link
Contributor

@ColinMaudry ColinMaudry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour les parties que je comprends, ça me paraît 👍🏻

@vmttn vmttn closed this Sep 13, 2023
@vmttn vmttn deleted the vmttn/feat/extract-grist branch October 24, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants