Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): force relation adresses/geocodages #301

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

vmttn
Copy link
Contributor

@vmttn vmttn commented Sep 19, 2024

Adresses can be deleted by the provider, or by us. In both cases, deleting the corresponding geocodages is required to ensure that the relationship between adresses and geocodages stands.

Either that or the relationship test must be downgrade to a warning.

@vmttn
Copy link
Contributor Author

vmttn commented Sep 19, 2024

fyi non testable via unittest. Mais j'ai validé le fait que le datatest fonctionne de nouveau

Adresses can be deleted by the provider, or by us.
In both cases, deleting the corresponding geocodages is required
to ensure that the relationship between adresses and geocodages stands.

Either that or the relationship test must be downgrade to a warning.
Copy link
Contributor

@vperron vperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant et simple le post_hook. Effectivement je trouve ça plus clair/clean de retirer les adresses en trop plutôt que de laisser s'accumuler des valeurs inutiles.

@vmttn vmttn merged commit fdd5639 into main Sep 19, 2024
7 of 9 checks passed
@vmttn vmttn deleted the vmttn/fix/relationship-between-adresses-and-geocodages branch September 19, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants