Skip to content

Commit

Permalink
refactor(api)
Browse files Browse the repository at this point in the history
  • Loading branch information
vmttn committed Jul 3, 2023
1 parent b15450d commit 7827dbc
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
3 changes: 3 additions & 0 deletions api/src/data_inclusion/api/core/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ def on_error(conn: HTTPConnection, exc: Exception) -> responses.Response:

class AuthenticationBackend(authentication.AuthenticationBackend):
async def authenticate(self, conn):
if "Authorization" not in conn.headers:
return

http_bearer_instance = HTTPBearer()

try:
Expand Down
2 changes: 1 addition & 1 deletion api/src/data_inclusion/api/core/request/services.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def save_request(request: requests.Request, response: responses.Response) -> Non
method=request.method,
path=request.url.path,
base_url=str(request.base_url),
user=request.user.username,
user=request.user.username if request.user.is_authenticated else None,
path_params=request.path_params,
query_params=dict(request.query_params),
client_host=request.client.host,
Expand Down
11 changes: 10 additions & 1 deletion api/tests/core/test_request.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,13 @@ def test_save_api_request_without_token(api_client, db_session):
response = api_client.get(url)

assert response.status_code == 403
assert db_session.query(models.Request).count() == 0
assert db_session.query(models.Request).count() == 1

request_instance = db_session.query(models.Request).first()
assert request_instance.status_code == 403
assert request_instance.user is None
assert request_instance.path == "/api/v0/structures"
assert request_instance.method == "GET"
assert request_instance.path_params == {}
assert request_instance.query_params == {}
assert request_instance.endpoint_name == "list_structures_endpoint"

0 comments on commit 7827dbc

Please sign in to comment.