Treatment for spglib v2.5.0 DeprecationWarning #105
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From spglib v2.5.0,
spglib.get_symmetry_dataset()andspglib.get_spacegroup_type()return kinds of dataclass, and dot access instead of dict key is recommended. Therefore, the dict access emits DeprecationWarning.https://spglib.readthedocs.io/en/stable/api/python-api/spglib/spglib.html#spglib.SpglibDataset
https://spglib.readthedocs.io/en/stable/api/python-api/spglib/spglib.html#spglib.SpaceGroupType
This PR is to prevent it. I added a function
get_dot_access_dataset, which mimics dot access for those dictionary for spglib < v2.5.0.