Merge pull request #18 from laszlocph/ports-support

Supporting a list of ports
gimlet-io · Apr 28, 2021 · b11b62a · b11b62a
2 parents e539810 + 5012c4a
commit b11b62a
Show file tree

Hide file tree

Showing 4 changed files with 94 additions and 21 deletions.
diff --git a/charts/onechart/templates/deployment.yaml b/charts/onechart/templates/deployment.yaml
@@ -54,12 +54,16 @@ spec:
             {{- end }}
           {{- end }}
           ports:
-            {{- if not .Values.containerPortYaml }}
+            {{- if not .Values.ports }}
             - name: http
               containerPort: {{ .Values.containerPort }}
               protocol: TCP
             {{ else }}
-              {{- toYaml .Values.containerPortYaml | nindent 12 }}
+            {{- range .Values.ports }}
+            - name: {{ .name }}
+              containerPort: {{ .containerPort }}
+              protocol: TCP
+            {{- end }}
             {{- end }}
           {{- if .Values.probe.enabled }}
           readinessProbe:

diff --git a/charts/onechart/templates/service.yaml b/charts/onechart/templates/service.yaml
@@ -8,12 +8,24 @@ metadata:
 spec:
   type: {{ if .Values.nodePortEnabled }}NodePort{{ else }}ClusterIP{{ end }}
   ports:
+    {{- if not .Values.ports }}
     - port: {{ if .Values.svcPort }}{{ .Values.svcPort }}{{ else }}{{ .Values.containerPort }}{{ end }}
       targetPort: http
       protocol: TCP
       name: http
       {{- if .Values.nodePort }}
       nodePort: {{ .Values.nodePort }}
       {{- end }}
+    {{ else }}
+    {{- range .Values.ports }}
+    - name: {{ .name }}
+      port: {{ if .svcPort }}{{ .svcPort }}{{ else }}{{ .containerPort }}{{ end }}
+      {{- if .nodePort }}
+      nodePort: {{ .nodePort }}
+      {{- end }}
+      targetPort: {{ .name }}
+      protocol: TCP
+    {{- end }}
+    {{- end }}
   selector:
     {{- include "helm-chart.selectorLabels" . | nindent 4 }}
diff --git a/.../deployment_contianer_port_yaml_test.yaml → ...onechart/tests/deployment_ports_test.yaml b/.../deployment_contianer_port_yaml_test.yaml → ...onechart/tests/deployment_ports_test.yaml
@@ -5,35 +5,26 @@ templates:
 tests:
   - it: Should set custom ports
     set:
-      containerPortYaml:
-        - port: 21
-          targetPort: ftp
-          protocol: TCP
+      ports:
+        - containerPort: 21
           name: ftp
-        - port: 3001
-          targetPort: passive-1
-          protocol: TCP
+        - containerPort: 3001
           name: passive-1
-        - port: 3002
-          targetPort: passive-2
-          protocol: TCP
+        - containerPort: 3002
           name: passive-2
     asserts:
       - equal:
           path: spec.template.spec.containers[0].ports
           value:
-            - port: 21
-              targetPort: ftp
+            - name: ftp
+              containerPort: 21
               protocol: TCP
-              name: ftp
-            - port: 3001
-              targetPort: passive-1
+            - name: passive-1
+              containerPort: 3001
               protocol: TCP
-              name: passive-1
-            - port: 3002
-              targetPort: passive-2
+            - name: passive-2
+              containerPort: 3002
               protocol: TCP
-              name: passive-2
   - it: Should set default port
     asserts:
       - equal:

diff --git a/charts/onechart/tests/service_ports_test.yaml b/charts/onechart/tests/service_ports_test.yaml
@@ -0,0 +1,66 @@
+suite: test deployment
+templates:
+  - service.yaml
+tests:
+  - it: Should set custom ports
+    set:
+      ports:
+        - containerPort: 21
+          name: ftp
+        - containerPort: 3001
+          name: passive-1
+        - containerPort: 3002
+          name: passive-2
+    asserts:
+      - equal:
+          path: spec.ports
+          value:
+            - name: ftp
+              port: 21
+              targetPort: ftp
+              protocol: TCP
+            - name: passive-1
+              port: 3001
+              targetPort: passive-1
+              protocol: TCP
+            - name: passive-2
+              port: 3002
+              targetPort: passive-2
+              protocol: TCP
+  - it: Should set custom svc port
+    set:
+      ports:
+        - containerPort: 2021
+          svcPort: 21
+          name: ftp
+        - containerPort: 3001
+          nodePort: 33001
+          name: passive-1
+        - containerPort: 3002
+          name: passive-2
+    asserts:
+      - equal:
+          path: spec.ports
+          value:
+            - name: ftp
+              port: 21
+              targetPort: ftp
+              protocol: TCP
+            - name: passive-1
+              port: 3001
+              nodePort: 33001
+              targetPort: passive-1
+              protocol: TCP
+            - name: passive-2
+              port: 3002
+              targetPort: passive-2
+              protocol: TCP
+  - it: Should set default port
+    asserts:
+      - equal:
+          path: spec.ports
+          value:
+            - port: 80
+              targetPort: http
+              protocol: TCP
+              name: http