Merge pull request #147 from gimlet-io/feat/pod-annotations-cron-job

feat: ability to add pod annotations for cron-job template
gimlet-io · Oct 8, 2024 · 24f03ea · 24f03ea
2 parents a45da57 + db7ee90
commit 24f03ea
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/charts/cron-job/templates/cronJob.yaml b/charts/cron-job/templates/cronJob.yaml
@@ -13,6 +13,11 @@ spec:
   jobTemplate:
     spec:
       template:
+        metadata:
+          annotations:
+            {{- with .Values.podAnnotations }}
+              {{- toYaml . | nindent 12 }}
+            {{- end }}
         spec:
           {{- with .Values.imagePullSecrets }}
           imagePullSecrets:

diff --git a/charts/cron-job/tests/cronjob_pod_annotations_test.yaml b/charts/cron-job/tests/cronjob_pod_annotations_test.yaml
@@ -0,0 +1,17 @@
+suite: test cron job
+templates:
+  - cronJob.yaml
+tests:
+  - it: Should set pod annotations
+    set:
+      podAnnotations:
+        annotation-one: no-such-annotation
+        annotation-two: no-such-annotation
+    asserts:
+      - template: cronJob.yaml
+        documentIndex: 0
+        equal:
+          path: spec.jobTemplate.spec.template.metadata.annotations
+          value:
+            annotation-one: no-such-annotation
+            annotation-two: no-such-annotation