Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform the true Chef run in Travis CI (linux and mac environments) #32

Closed
wants to merge 5 commits into from
Closed

Perform the true Chef run in Travis CI (linux and mac environments) #32

wants to merge 5 commits into from

Conversation

rjaros87
Copy link
Contributor

@rjaros87 rjaros87 commented Jul 1, 2016 •
edited
Loading

Major changes:

Minor changes:

  • Increase Ruby version for workstation to 2.2.2
  • Corrected the Berksfile
  • Added bats test (it could be also used for the kitchen test)

@rjaros87
Copy link
Contributor Author

rjaros87 commented Jul 1, 2016 •
edited
Loading

@gildegoma please review. First three commits are from previous pull request #29 whicha are necessary in this PR

@gildegoma
Copy link
Owner

@rjaros87 this looks great again! It actually resolves some points I also hit while I started to review your #29.
I'd really love to get this in very soon, but having all the things together might unfortunately slow down the review/test process... I try to come back to you as soon as possible, maybe with suggestion to split/postpone a little bit. But don't worry, we'll get there for sure!

@gildegoma
Copy link
Owner

@rjaros87 don't move for the moment, I'll give you a wish of roadmap ;-)

@rjaros87
Copy link
Contributor Author

rjaros87 commented Jul 1, 2016

Ok. If you merge #29 , from this PR should disappear first three commits automatically and should stay visible only new one.

@rjaros87
Copy link
Contributor Author

rjaros87 commented Jul 1, 2016

I'll give you a wish of roadmap ;-)

Windows support? ;D

@rjaros87
Copy link
Contributor Author

rjaros87 commented Jul 1, 2016

Little update - README.md

@rjaros87 rjaros87 mentioned this pull request Jul 24, 2016
Open
Brantone
Brantone reviewed Jan 25, 2017
View reviewed changes
recipes/default.rb
end
end
%w(android-update-sdk).each do |android_helper_script|
template File.join(node['android-sdk']['scripts']['path'], android_helper_script) do
source "#{android_helper_script}.erb"
owner node['android-sdk']['scripts']['owner']
group node['android-sdk']['scripts']['group']
mode 0755
group node['android-sdk']['scripts']['group'] unless mac_os_x?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the limit on mac_os_x ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some trouble to set properly group on mac, but now it doesn't occurs. I will remove unless mac_os_x? today and recommit to branch.

@Brantone
Copy link

Curious what's holding up the merge?

@gildegoma
Copy link
Owner

Closed in favour of #33 (including these changes as well).

@gildegoma gildegoma closed this Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brantone Brantone Brantone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjaros87 @gildegoma @Brantone