Loop over node components to generate project string for maven-android-sdk-deployer

[ruleant]

It checks for package prefixes and converts to folders :

• platforms
• add-ons
• repositories
• extras

A few packages in extra's have name that differs from the targets in maven-android-sdk-deployer, these are not yet covered by this script :

• admob
• google-play-services-for-froyo
• ...

Possible solutions :

• convert the name in the script to match the targets in maven-android-sdk-deployer
• rename these targets in maven-android-sdk-deployer : Update : I created a pull request renaming the targets : rename modules to reflect android sdk package names simpligility/maven-android-sdk-deployer#225 (@mosabua), which was merged.

[gildegoma]

First sorry for the long delay to respond!

Your changes in the Chef recipe work fine, but unfortunately this approach solves only half of the problem:

• OK: maven-android-sdk-deployer will be used when building the VM image (in Chef cookbook context)
• Missing: maven-android-sdk-deployer should also be transparently integrated when installing/upgrading android components with scripts like android-update-sdk (for instance, this is required in Travis CI context when installing additional components).

In order to keep the things DRY, I'd like to use the same piece of code for both situations.
I see two possible approaches:

• Rewrite your folder mapping into a shell script, that will be used during Chef provisioning, but also installed on the VM for later usage.

or

• Get rid of this extra mapping by updating maven-android-sdk-deployer itself to deal with the same component identifiers as Android SDK does.

According to @mosabua's 566d5f0#commitcomment-6314505, the second approach seems reasonable and I think that it would offer the best solution (for both perspectives: maintenance and end-usage).

@ruleant Do you think that the second option is (easily) doable?

---

PS Apologies: The above "DRY" argumentation is currently not applied between cookbook recipe and android-accept-licenses script. Sorry for the confusion, this could have brought!

[ruleant]

Hi,

The second option makes the most sense, because this could benefit other users (outside travis environment) of maven-android-sdk-deplorer, because the same package names as android sdk install can be used when deploying them to the local maven repo.

That said, I guess creating extra profiles, matching the package names in Android SDK, in maven-android-sdk-deplorer redirecting to the right subfolder is a way to do it and should be feasable. (But I'm not a maven specialist, so there might be more efficient ways to do this)

However, I can't promise when I will find to time to give it a go.

[gildegoma]

Thanks @ruleant. I close this one in favor of simpligility/maven-android-sdk-deployer#236.

I won't have time to work on this in the next weeks, but we keep going on :)