Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better support for mac_os_x #25

Open
Brantone opened this issue Nov 16, 2015 · 7 comments
Open

Provide better support for mac_os_x #25

Brantone opened this issue Nov 16, 2015 · 7 comments
Milestone

Comments

@Brantone
Copy link

expect is typically default installed on OSX, so not always needed, thus 'homebrew' not required either (and some instances 'homebrew' might not be allowed anyway).

More importantly /etc/profile.d does not exist, thus https://github.com/gildegoma/chef-android-sdk/blob/master/recipes/default.rb#L91 fails - although set_environment_variables can be used to to circumvent, would be nice still set and have legit.

@gildegoma
Copy link
Owner

@Brantone thanks for filing these issues. At the moment, this cookbook is not officially supporting the Mac OS X platform.

Instead of patching isolated items (e.g. expect optional setup - #26), I'd prefer to address mac_os_x support as a whole. Relying on homebrew's android-sdk could be a good start, although Hombrew default approach is to only provide the latest stable release (i.e. no easy version selection). Or do you think that this cookbook should indeed offer an "advanced" alternative to the hombrew way?

@Brantone
Copy link
Author

Ultimately it would be nice to see this move towards LWRP, but in interim, the 2 main hurdles to some semblance of osx support is expect and /etc/profile.d, both of which being pretty straight forward to solve. Because expect is usually standard on OSX machines, could take a gamble on it being installed ... as for profile.d, the OSX equivalent is /etc/paths.d and is a modified version of android-sdk.sh.erb

@gildegoma
Copy link
Owner

@Brantone and then this cookbook will be fully independent of any Mac package manager (e.g. no call to any package resource), correct?

@Brantone
Copy link
Author

That's my current line of reasoning, yes ... always open to suggestions on something I might have missed.

@gildegoma
Copy link
Owner

So far LGTM, are you willing to provide a pull request for this then?

@Brantone
Copy link
Author

You mean LWRP (light weight resource provider)? ... I wish I had time to do it sooner rather than later :( might not be for a while yet.

@gildegoma
Copy link
Owner

No, I am currently not interested to introduce the LWRP. Only the points you mentioned above:

  • use package 'expect' only on a linux platform (or not on a mac platform) - replacing Allow ignoring installing expect #26. We then have no dependency on homebrew.
  • deal with /etc/paths.d when running on a mac platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants