Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

add basic test checking deployment status #51

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented Oct 4, 2023

Signed-off-by: Matias Charriere [email protected]

This PR:

  • Adds tests

It should fail the first run, but go well after merging #49

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

@mcharriere mcharriere requested a review from a team as a code owner October 4, 2023 19:39
Signed-off-by: Matias Charriere <[email protected]>
Signed-off-by: Matias Charriere <[email protected]>
Signed-off-by: Matias Charriere <[email protected]>
Signed-off-by: Matias Charriere <[email protected]>
Signed-off-by: Matias Charriere <[email protected]>
Signed-off-by: Matias Charriere <[email protected]>
@mcharriere
Copy link
Contributor Author

now tests are working :)

Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would testing in service-mesh-bundle also make sense?

@mcharriere
Copy link
Contributor Author

Would testing in service-mesh-bundle also make sense?

yes definitively. I even considered using it here (as this is bascially installing 3 apps) but I faced a few issues with installing the bundle itself.
I'd like to test the bundle using the tekton pipelines instead of kind; as it's more realistic.

@mcharriere mcharriere merged commit 69cf25d into main Oct 5, 2023
4 checks passed
@mcharriere mcharriere deleted the add-basic-tests branch October 5, 2023 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants