-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Adds 2D membrane-bound diffusion and 2D/3D interaction #5
Open
tjclement
wants to merge
96
commits into
gfrd:master
Choose a base branch
from
tjclement:feature/plane_edges
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cles to PlanarSurfaces.
…ticle_radius (as mentioned in paper)
…al shell sizes causing immediate escapes
…ger than r0. Such situations caused tremendously small time deltas
…roll wheel on *NIX systems
* feature/ccd: Changes needed to compile on latest Mac OS
… implemented saving simstate for all new domain types
…culation, preventing creation of domains
… bug, modified and added validation models
…lushes to copynumbers and reaction record files so they can be monitored in real-time during a simulation run.
…fixed K_d calculation
…inux machines that installed it through a package manager
…always having whitespace between numerics in the rows
… PairPlanar, to prevent convergence error loops
…plane_edges * commit 'cd567b1ff0c2b20a4c0a9d72d30118cfe7596788': Update for VS2019, minor formatting fixes. # Conflicts: # CMakeSettings.json # src/eGFRD/EGFRDSimulator.hpp # src/eGFRD/Single.hpp
…plane_edges * commit '0f5dded6c93f8f49f696943182603f1f580a6929': Update build-information for libccd requirement. Use libCCD for Cylinder/Cylinder collision testing. Added tests for orientation and scaling (libCCD does not handle small values very well). Visualizer demo 5 shows work. # Conflicts: # samples/equilibrium/equilibrium.gfrd # src/eGFRD/CMakeLists.txt # src/eGFRD/EGFRDSimulator.hpp # src/eGFRD/ShellCreateUtils.hpp # src/gfrdVisualizer/gfrdVisualizer.cpp # test/TestCCD/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work of my MSc project has not yet been merged into upstream, and it would be good to do so so others can expand on it.
The code is operational, but contains some simulation irregularities, as described in section 5.1 of the thesis "Simulation of multiplexing in immune cell receptors using eGFRD". Pieter Rein ten Wolde can provide a copy to those who would like to know more.
I would suggest that this work is not yet merged into upstream master, but rather into a separate feature branch, until the irregularities have been studied further.