feat: Add getter methods for Scope class #3102
Conversation
iKlotho
changed the title
|
@iKlotho I would prefer to find an alternative solution to your problem, rather than add new public APIs to the Can you please explain exactly why you need these getter methods? |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
3 similar comments
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
The getter methods would allow users to check if a specific tag/context/extra is already set or not. I have a use case like this and I don't want to access the protected members of a class. This PR adds getter methods for the following variables:
_tags,_contexts, and_extras. If adding getter methods for _contexts and _extras doesn't make sense, I can remove them; however, I think they will be useful.