This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Define how tracing and performance can be separated #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
smeubank
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While much of distributed tracing was introduces in many places at Sentry with the perofrmance product. Tracing is not tied to performance, in any way "by design".
Meaning any products of sentry should be linkable by traces regardless of the usage of the Performance product.
This change proposed would define how SDKs should behave with existing options. This obeys our promise to users, and we only need to check how all SDKs behave in actuality of this situation.
Open point:
Tracing could be on by default for all sentry SDKs, and this option is then simply to turn it off.
https://develop-git-smeubank-tracing-sans-performance.sentry.dev/sdk/performance/#separation-of-sampling-transcations-and-trace-propagation
getsentry/sentry#45725