Skip to content

Commit

Permalink
JSDoc todos on current/instance expression predicates reference grammar
Browse files Browse the repository at this point in the history
This corrects the previous copypasta mistake, and makes the notes more general so they don’t overly influence reasoning about the gap in behavior
  • Loading branch information
eyelidlessness committed Jul 22, 2024
1 parent c5b8ac7 commit 1d4de28
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/xforms-engine/src/parse/xpath/semantic-analysis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const isCurrentFunctionCall = (syntaxNode: FunctionCallNode): boolean => {
* - `current()/...` (where `...` represents additional steps)
* - `current()//...` (^)
*
* @todo XPath grammar technically also allows for `current()[some-predicate]`,
* @todo XPath grammar technically also allows for FilterExpr[Predicate],
* and our `tree-sitter-xpath` grammar/parser also allow for this. But
* `@getodk/xpath` types do not currently acknowledge this possibility.
*/
Expand Down Expand Up @@ -144,7 +144,7 @@ const isInstanceFunctionCall = (syntaxNode: FunctionCallNode): boolean => {
* - `instance("id")/...` (where `...` represents additional steps)
* - `instance("id")//...` (^)
*
* @todo XPath grammar technically also allows for `current()[some-predicate]`,
* @todo XPath grammar technically also allows for FilterExpr[Predicate],
* and our `tree-sitter-xpath` grammar/parser also allow for this. But
* `@getodk/xpath` types do not currently acknowledge this possibility.
*/
Expand Down

0 comments on commit 1d4de28

Please sign in to comment.