Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Fix #358 #362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix #358 #362

wants to merge 3 commits into from

Conversation

maharishi-01
Copy link

@maharishi-01 maharishi-01 commented Feb 20, 2020

Closes #358

What has been done to verify that this works as intended?

Test on android 9.
Go to Main Activity
Click Receive(if you are not in Bluetooth mode switch to Bluetooth mode)

Why is this the best possible solution? Were any other approaches considered?

Looking great.

How does this change affect users? Describe intentional changes to behaviour and behaviour that could have accidentally been affected by code changes. In other words, what are the regression risks?

good User experience.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.

@maharishi-01
Copy link
Author

i don't know why it show error

@maharishi-01
Copy link
Author

please help me

@ajay-prabhakar
Copy link
Contributor

Hello, @MahaRishi1 as you are new to the community I am just saying some things we should fallow and it is really helpful if you read contributing guidelines

  • if any new feature we have to discuss with mentors(applies for this issue) do not work before that
  • Don't put PR's before assigning to you so, no one has any confusions
  • Before putting PR run ./gradlew checkcode locally in the terminal if you have any error you can detailed info about that

@huangyz0918
Copy link
Contributor

Thanks @Chromicle for such clear guide and suggestions. Another thing is @MahaRishi1 , if you add a brief title to this PR, it will be better and more friendly to other reviewers.

@ajay-prabhakar
Copy link
Contributor

ajay-prabhakar commented Mar 3, 2020

@MahaRishi1 are you still working on this
if yes, fix the build issue

@maharishi-01
Copy link
Author

Yes I am trying.....but the one of the ci/circlei is failed.....so I am still stuck in it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI of scanning devices of bluetooth
3 participants