Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

fix: list only smart phones for scanning bluetooth devices #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajay-prabhakar
Copy link
Contributor

@ajay-prabhakar ajay-prabhakar commented Jan 31, 2020

Closes #346

What has been done to verify that this works as intended?

  • Checked whether it is listing the smartphones are only or not
  • Checked whether any new warnings are produced by adding this code
  • Checked any tests are failing
  • Checked by changing the orientation of the devices
  • Checked by transferring Forms

Why is this the best possible solution? Were any other approaches considered?

With the help of BluetoothClass checked if the device is the smartphone then added into Bluetooth device list with help of if the condition

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

By adding this fix user can directly select the device to transfer forms

GIF

list of devices before this feature

before

list of devices after this feature

after

Before submitting this PR, please make sure you have:

  • run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.

@ajay-prabhakar
Copy link
Contributor Author

@lakshyagupta21 can you please review my PR's if you are free
I made PR's for all the issues I claimed

Copy link
Contributor

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question @Chromicle , have you test for the android tablets? Is the change disable the tablets?

@ajay-prabhakar
Copy link
Contributor Author

have you test for the android tablets? Is the change disable the tablets?

@huangyz0918 My friend checked and he said it is showing as expected

@lakshyagupta21 I added the check for NPE, can you please review now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: listing all devices of bluetooth
3 participants