This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244, #233, #262, #318
What has been done to verify that this works as intended?
Have a look: fixed along with new updates, and handled Security Exceptions, and other warnings.
https://drive.google.com/file/d/1TGT0vvEMRE7h-_ssFlpjdqnOZ2zDnFWs/view?usp=sharing
Why is this the best possible solution? Were any other approaches considered?
Using TextWatcher is a good approach if we need to check text changes in a particular EditText. There are some other solutions using Observer. And LiveData. As i've seen the current architecture of application. This approach is meaningful with less changes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I considered the same approach of activation Hotspot in Samsung M20 device, and given almost same behavior while making changes in current code. This looks better now with extra UE.
Before submitting this PR, please make sure you have:
./gradlew checkCode
and confirmed all checks still pass OR confirm CircleCI build passes(https://github.com/opendatakit/share/blob/master/share_app/src/main/assets/open_source_licenses.html).
--------First look when dialog becomes visible on the screen------------