feat: Made Directory Picker instead of edittext #251

ajay-prabhakar · 2019-04-29T12:32:53Z

Closes #250

What has been done to verify that this works as intended?

Checked whether selected Directory is taking as a summary and file path value
Checked all other preferences whether they are working properly or not
Checked in some phones(Android 7,8,9) whether the intent is working properly or not
Checked whether it is taking sdCard or not along with internal storage
Checked whether it is working perfectly in lower android devices

Why is this the best possible solution? Were any other approaches considered?

As due to there is no default file manager in lesser android devices so the devices lesser than API 19
will get the editText for a directory path and greater android devices will get the directory picker so they directly can pick the whatever the folder they want

Implementation of Directory picker
I made Intent Intent.ACTION_OPEN_DOCUMENT_TREE so by clicking on that we can see all files in a device
By that, I added another method onActivityResult so we can get the file path through (data.getData()).getPath() without any typos

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Mainly, It will avoid the typos regarding Directory names and user can directly select the Directory easily

GIF

Greater Android Devices

Lesser android Devices

Before submitting this PR, please make sure you have:

run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
verified that any code or assets from external sources are properly credited in comments and/or in the about file.

iadeelzafar

Great work @Chromicle
LGTM

lakshyagupta21 · 2019-06-04T18:24:48Z

skunkworks_crow/src/main/java/org/odk/share/preferences/SettingsPreference.java

+        switch (requestCode) {
+            case DIRECTORY_REQUEST_CODE:
+                try {
+                    String filePath = (data.getData()).getPath();


(data.getData()).getPath() can be written as data.getData().getPath()

lakshyagupta21 · 2019-06-04T18:25:31Z

skunkworks_crow/src/main/java/org/odk/share/preferences/SettingsPreference.java

+            case DIRECTORY_REQUEST_CODE:
+                try {
+                    String filePath = (data.getData()).getPath();
+                    filePath = filePath + getString(R.string.directory_odk);


filePath = filePath + getString(R.string.directory_odk); can be written as filePath = filePath + getString(R.string.directory_odk);

lakshyagupta21 · 2019-06-04T18:26:07Z

skunkworks_crow/src/main/java/org/odk/share/preferences/SettingsPreference.java

@@ -159,4 +155,25 @@ private void showPasswordDialog() {
        AlertDialog alertDialog = builder.create();
        alertDialog.show();
    }
+
+    public void chooseDirectory() {


@Chromicle Have you tried handling when there is no intent to handle directory picker?

Yeah, I tried but it does not give better results alike as putting intent
But I checked in Android 6,7,8,9 phones whether the intent is working or not it is perfectly working

I tried this in Android 4.4 version and I was not able to select any directory. Can you please verify or can you think of any fallback mechanism?

Since there is no "default file manager" in KitKat it is not working if the user is installed a particular 3rd party file manager then it may works

@Chromicle If we are adding some feature then we should be confident enough that it won't break anything which was working previously. So adding this feature will not work as well as won't allow user to manually write the directory path. So I would suggest you rather than printing log or toast it would be beneficial to have some fallback mechanism for some devices in which directory picker is not available.
One more suggestion I would like to give that whenever you're doing some kind of testing then always try to test on less than 5.

lakshyagupta21 · 2019-06-04T18:26:47Z

Also resolve conflicts.

lakshyagupta21 · 2019-08-18T04:23:53Z

@Chromicle Are you still working on this, because I see that few of the above issues are still not resolved related to lower Android devices

ajay-prabhakar · 2019-08-18T06:24:30Z

@Chromicle Are you still working on this, because I see that few of the above issues are still not resolved related to lower Android devices

@lakshyagupta21 I resolved in the way that for android version less than KitKat they will get the edit text and android versions greater than that will get the directory picker
I pick this approach because we can not the data from the path of lesser android versions

lakshyagupta21 · 2019-08-18T06:52:20Z

@Chromicle I would recommend you to run ./gradlew checkCode on every commit you push because sometimes we miss something due to which it fails and also check the checkboxes in the PR description that you've done both the things mentioned there.

Before submitting this PR, please make sure you have:

run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes

verified that any code or assets from external sources are properly credited in comments and/or in the about file.

lakshyagupta21 · 2019-08-18T07:32:51Z

@Chromicle Please update your PR template.

ajay-prabhakar · 2019-08-18T09:07:18Z

@Chromicle Please update your PR template.

Yeah I updated can you please check it

lakshyagupta21 · 2019-08-18T12:49:21Z

skunkworks_crow/src/main/java/org/odk/share/views/ui/settings/SettingsActivity.java

-    CheckBoxPreference passwordRequirePreference;
-    EditTextPreference odkDestinationDirPreference;
+    SwitchPreference passwordRequirePreference;
+    Preference odkDestinationDirPreferenceDirectoryPicker;


Creating two different preferences is fine, but the values that we get from these two different preferences on different versions stored separately. Ideally, whatever value that we receive from these UI Objects should be saved to the same preference.

I tried that but I am getting preference cast exception

I'll give it a shot then will suggest the solution

Yeah than you

skunkworks_crow/src/main/java/org/odk/share/tasks/DownloadJob.java

lakshyagupta21 · 2019-08-18T12:53:46Z

@Chromicle due to some recent commits, now this PR again have some merge conflicts can you resolve them, and do a dev testing like transfer a form from one device to another and check if you're able to see the entries in the selected directory or not.

Directory Picker Fixed typos fixed Null pointer exception reformated code in xml added /ODK to filePath Changed method names Added /odk Deleted some unused changes Made code Checkstyle removed unused strings

ajay-prabhakar force-pushed the directory branch from 43b1921 to 5e36e79 Compare April 29, 2019 13:11

iadeelzafar approved these changes Apr 29, 2019

View reviewed changes

lakshyagupta21 suggested changes Jun 4, 2019

View reviewed changes

lakshyagupta21 suggested changes Aug 18, 2019

View reviewed changes

Directory Picker

e5cebb3

Directory Picker Fixed typos fixed Null pointer exception reformated code in xml added /ODK to filePath Changed method names Added /odk Deleted some unused changes Made code Checkstyle removed unused strings

ajay-prabhakar force-pushed the directory branch from 3775bd5 to e5cebb3 Compare November 29, 2019 17:17

ajay-prabhakar added 2 commits November 29, 2019 22:50

Added Directory picker

bccdac9

Solved conflicts

73f18bd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Made Directory Picker instead of edittext #251

feat: Made Directory Picker instead of edittext #251

ajay-prabhakar commented Apr 29, 2019 •

edited

Loading

iadeelzafar left a comment

lakshyagupta21 Jun 4, 2019

lakshyagupta21 Jun 4, 2019

lakshyagupta21 Jun 4, 2019

ajay-prabhakar Jun 5, 2019

lakshyagupta21 Jun 6, 2019

ajay-prabhakar Jun 11, 2019

lakshyagupta21 Jun 11, 2019

lakshyagupta21 commented Jun 4, 2019

lakshyagupta21 commented Aug 18, 2019

ajay-prabhakar commented Aug 18, 2019 •

edited

Loading

lakshyagupta21 commented Aug 18, 2019

Before submitting this PR, please make sure you have:

lakshyagupta21 commented Aug 18, 2019

ajay-prabhakar commented Aug 18, 2019

lakshyagupta21 Aug 18, 2019

ajay-prabhakar Aug 18, 2019

lakshyagupta21 Aug 18, 2019

ajay-prabhakar Aug 18, 2019

lakshyagupta21 commented Aug 18, 2019

feat: Made Directory Picker instead of edittext #251

Are you sure you want to change the base?

feat: Made Directory Picker instead of edittext #251

Conversation

ajay-prabhakar commented Apr 29, 2019 • edited Loading

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

GIF

Greater Android Devices

Lesser android Devices

Before submitting this PR, please make sure you have:

iadeelzafar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lakshyagupta21 commented Jun 4, 2019

lakshyagupta21 commented Aug 18, 2019

ajay-prabhakar commented Aug 18, 2019 • edited Loading

lakshyagupta21 commented Aug 18, 2019

Before submitting this PR, please make sure you have:

lakshyagupta21 commented Aug 18, 2019

ajay-prabhakar commented Aug 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lakshyagupta21 commented Aug 18, 2019

ajay-prabhakar commented Apr 29, 2019 •

edited

Loading

ajay-prabhakar commented Aug 18, 2019 •

edited

Loading