Feat : added flash light while scanning QRcode #240

ajay-prabhakar · 2019-04-05T10:11:05Z

Closes #239

What has been done to verify that this works as intended?

Whether it is turning on flash when we clicked the button
checked is the forms are transferring or not
when we exit activity whether is it turning off or not

Why is this the best possible solution? Were any other approaches considered?

I made a new class ScannerActivity in that implemented the DecoratedBarcodeView.TorchListener so it can turn on or off by user input
made 2 drawable files for flashlight button(on state and off state) instead of direct buttons
and changed the setCaptureActivity to ScannerActivity it is working fine as expected

I find the solution in one of the stack overflow posts is here

How does this change affect users?

By flashlight, if the user wants the flash then he will turn on or else he can turn off so the scanning of QR code can be done easily

GIF

Before submitting this PR, please make sure you have:

run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
verified that any code or assets from external sources are properly credited in comments and/or in the about file.

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java

lakshyagupta21 · 2019-04-05T16:41:44Z

skunkworks_crow/src/main/res/drawable/ic_flash_off_black_24dp.xml

@@ -0,0 +1,5 @@
+<vector android:height="24dp" android:tint="#ffffff"


If you've used any external open source library or some other source in creating the asset, then also mention in the open_source_licenses file, and if you referred any code from some external source you should also mention that as well.

No I didnot use any open source library I find the solution in stack overflow for implementing flash light ,other layout things I implemented

I thought you used an asset from some other source, and even if you're referring to any other source its always good to add the source link in the code, it helps other developers in understanding things better.

yeah, I updated in PR template and I changed the object name also
my builds are failing due to changes of #230

so I made some changes to #230 can you please review now

There is some redundancy to this vector. It is filled with black color and then tinted with white. Shouldn't it be filled with white and then you wouldn't require a tint at all

@Chromicle Can you add the link of stackoverflow in the code itself maybe in the activity wherever you have used the snippet, this way it can be referred easily.

Yeah, I will Do it now

Yeah, Done can you have a look once now

lakshyagupta21 · 2019-04-05T16:45:26Z

This PR contains a lot of commits, @Chromicle try squashing your commits.

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java

shobhitagarwal1612 · 2019-04-06T17:17:03Z

skunkworks_crow/src/main/res/drawable/ic_flash_off_black_24dp.xml

@@ -0,0 +1,5 @@
+<vector android:height="24dp" android:tint="#ffffff"


There is some redundancy to this vector. It is filled with black color and then tinted with white. Shouldn't it be filled with white and then you wouldn't require a tint at all

skunkworks_crow/src/main/res/drawable/ic_flash_on_black_24dp.xml

ajay-prabhakar · 2019-04-06T20:49:26Z

@shobhitagarwal1612 @lakshyagupta21 can you review now

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java

skunkworks_crow/src/main/java/org/odk/share/preferences/SettingsPreference.java

shobhitagarwal1612 · 2019-04-16T16:47:02Z

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java

+
+        //Initialize barcode scanner view
+
+        decoratedScannerView = findViewById(R.id.zxing_barcode_scanner);


That might happen if you are not binding views using Butterknife.bind(this) before using any injected variable.
In this case, you might be trying to setTorchListener. So, the solution is to do the binding first

shobhitagarwal1612 · 2019-04-16T16:49:43Z

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java

+
+    @OnClick(R.id.switch_flashlight)
+    public void toggleButton() {
+        if (isFlashlightSupported) {


This if condition will always be true. In onCreate(), you are setting the visibility to GONE if the feature isn't available. Hence, such a case where the button is clicked when the flashlight isn't available is not possible

This if condition will always be true. In onCreate(), you are setting the visibility to GONE if the feature isn't available. Hence, such a case where the button is clicked when the flashlight isn't available is not possible

Yeah, I didn't notice 🤪 , I updated it now

ajay-prabhakar · 2019-06-26T16:55:04Z

@lakshyagupta21 can you please review this PR also

huangyz0918 · 2019-08-20T02:19:42Z

@Chromicle It's a great feature, please resolve the conflicts. And you can squash some commits that have no more senses.

Added Flash light feature autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Made object name to camel case Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Changes for getodk#230 Changed QR code camel case Changed QR code camel case

ajay-prabhakar · 2019-08-21T11:33:59Z

@Chromicle It's a great feature, please resolve the conflicts. And you can squash some commits that have no more senses.

Yeah I did, I wrote tests for scannerActivity also can you please check that @lakshyagupta21 @huangyz0918

soumyajit1729 · 2020-02-03T10:24:56Z

Hello!! May I work on this issue ?

ajay-prabhakar · 2020-02-03T12:00:42Z

Hello @soumyajit1729, I made the changes as suggested and it is not yet reviewed can you find some other open issues 😄

ajay-prabhakar changed the title ~~Flashlight~~ Feat : added flash light while scanning QRcode Apr 5, 2019

lakshyagupta21 suggested changes Apr 5, 2019

View reviewed changes

ajay-prabhakar force-pushed the flashlight branch 6 times, most recently from c866f51 to c47e780 Compare April 6, 2019 09:35

shobhitagarwal1612 suggested changes Apr 6, 2019

View reviewed changes

ajay-prabhakar force-pushed the flashlight branch from 2248569 to a7a6e0d Compare April 6, 2019 20:50

shobhitagarwal1612 reviewed Apr 7, 2019

View reviewed changes

skunkworks_crow/src/main/java/org/odk/share/activities/ScannerActivity.java Outdated Show resolved Hide resolved

shobhitagarwal1612 reviewed Apr 7, 2019

View reviewed changes

skunkworks_crow/src/main/java/org/odk/share/preferences/SettingsPreference.java Outdated Show resolved Hide resolved

shobhitagarwal1612 suggested changes Apr 16, 2019

View reviewed changes

ajay-prabhakar mentioned this pull request Apr 28, 2019

When device orientation is changed no changes will happen #248

Open

2 tasks

ajay-prabhakar force-pushed the flashlight branch from fdd9884 to 82c7e2c Compare August 21, 2019 11:28

fixed conflicts

06f0bcb

Wrote Test for ScannerActivty

55fb194

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat : added flash light while scanning QRcode #240

Feat : added flash light while scanning QRcode #240

ajay-prabhakar commented Apr 5, 2019 •

edited by lakshyagupta21

Loading

lakshyagupta21 Apr 5, 2019

ajay-prabhakar Apr 6, 2019

lakshyagupta21 Apr 6, 2019

ajay-prabhakar Apr 6, 2019

ajay-prabhakar Apr 6, 2019 •

edited

Loading

shobhitagarwal1612 Apr 6, 2019

lakshyagupta21 Jun 3, 2019

ajay-prabhakar Jun 3, 2019

ajay-prabhakar Jun 3, 2019

lakshyagupta21 commented Apr 5, 2019

shobhitagarwal1612 Apr 6, 2019

ajay-prabhakar commented Apr 6, 2019

shobhitagarwal1612 Apr 16, 2019

shobhitagarwal1612 Apr 16, 2019

ajay-prabhakar Apr 16, 2019

ajay-prabhakar commented Jun 26, 2019

huangyz0918 commented Aug 20, 2019

ajay-prabhakar commented Aug 21, 2019 •

edited

Loading

soumyajit1729 commented Feb 3, 2020

ajay-prabhakar commented Feb 3, 2020

		@@ -0,0 +1,5 @@
		<vector android:height="24dp" android:tint="#ffffff"


		//Initialize barcode scanner view

		decoratedScannerView = findViewById(R.id.zxing_barcode_scanner);

Feat : added flash light while scanning QRcode #240

Are you sure you want to change the base?

Feat : added flash light while scanning QRcode #240

Conversation

ajay-prabhakar commented Apr 5, 2019 • edited by lakshyagupta21 Loading

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users?

GIF

Before submitting this PR, please make sure you have:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajay-prabhakar Apr 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lakshyagupta21 commented Apr 5, 2019

Choose a reason for hiding this comment

ajay-prabhakar commented Apr 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajay-prabhakar commented Jun 26, 2019

huangyz0918 commented Aug 20, 2019

ajay-prabhakar commented Aug 21, 2019 • edited Loading

soumyajit1729 commented Feb 3, 2020

ajay-prabhakar commented Feb 3, 2020

ajay-prabhakar commented Apr 5, 2019 •

edited by lakshyagupta21

Loading

ajay-prabhakar Apr 6, 2019 •

edited

Loading

ajay-prabhakar commented Aug 21, 2019 •

edited

Loading