-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3: handle 307 redirects #716
Open
alxndrsn
wants to merge
1
commit into
getodk:next
Choose a base branch
from
alxndrsn:s3-redirects
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Sep 19, 2024
alxndrsn
commented
Sep 19, 2024
alxndrsn
commented
Sep 19, 2024
alxndrsn
commented
Sep 19, 2024
alxndrsn
force-pushed
the
s3-redirects
branch
2 times, most recently
from
September 20, 2024 06:10
30162cc
to
ec65b68
Compare
alxndrsn
commented
Sep 20, 2024
alxndrsn
commented
Sep 20, 2024
alxndrsn
force-pushed
the
s3-redirects
branch
2 times, most recently
from
September 20, 2024 06:24
c61fbe7
to
1b5337d
Compare
lognaturel
force-pushed
the
s3-redirects
branch
from
September 20, 2024 17:44
1b5337d
to
67bd0ad
Compare
Capturing some quick initial thoughts that I will chew on for a bit:
I did a few rounds of looking at request time and got consistent results that look like about 200ms extra than without which is itself already more than when the blobs were in the db (these relative values depend most on speed of application server and speed of db server; these are meaningful because they're Cloud infrastructure): |
ktuite
added
backend
Requires a change to the API server
ops
Docker, ops to deploy Central
labels
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #715