Remove link to entity list on summary if new and unpublished #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Sep 12, 2023
| {{ dataset.name }} | ||
| </router-link> | ||
| <template v-else> |
There was a problem hiding this comment.
Instead of <template>, how about <span v-tooltip.text> in case the dataset name is very long?
There was a problem hiding this comment.
the outer div .dataset-name seems to take care of this already without changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend part of getodk/central#467 to de-linkify the name of a new entity list.
The corresponding backend change getodk/central-backend#974 makes it so if the user gets to the page that used to be in this link, it will say "resource not found" w/o any changes because backend now returns a 404 for getting details about an unpublished dataset.
What has been done to verify that this works as intended?
Trying it, tests.
Why is this the best possible solution? Were any other approaches considered?
I looked at the details coming back from the dataset-diff endpoint for a form draft, and
isNewon the dataset itself seemed like a good one to use to decided to create a link or not.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Less access to broken parts of frontend, more consistent behavior.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
n/a
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes