Added test for analytics of zero projects #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Aug 1, 2023
sadiqkhoja
pushed a commit
to sadiqkhoja/central-backend
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #763 but I've set up the issues so this frontend PR (getodk/central-frontend#836) will close it. This specific PR just adds a test.
What has been done to verify that this works as intended?
Didn't change any code, just added a test. I think we added analytics before we removed the default project, and then I was concerned backend was making a malformed response in that empty-project scenario. It's not -- it makes a reasonable response with an empty project array.
Why is this the best possible solution? Were any other approaches considered?
Didn't change any code.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Didn't change any code.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
No.
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes