Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systeminformation dependency #1002

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Sep 22, 2023

I updated the systeminformation package by running npm audit fix. systeminformation is a subdependency of pm2:

$ npm ls systeminformation
[email protected]
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

What has been done to verify that this works as intended?

Just running tests.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Given that the package is a subdependency within the allowed semver range, I'm hopeful that any risk of regression is low.

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

I ran the following command:

npm audit fix --legacy-peer-deps
Copy link
Member

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be ok to merge before release, risk seems low.

@matthew-white matthew-white merged commit 1de9b67 into master Sep 24, 2023
5 checks passed
@matthew-white matthew-white deleted the systeminformation branch September 24, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants