fix(membership): Ensure membership is in current organization when revoking #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix_membership_revoke_security
branch
from
56c0be5
to
5fa2482
Compare
lovrocolic
approved these changes
Oct 4, 2024
vincent-pochet
force-pushed
the
fix_membership_revoke_security
branch
from
5fa2482
to
c0b4a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Today it is possible the revoke a membership from any organization as long as you know the ID.
The
Mutations::Memberships::Revokeis delegating the logic toMemberships::RevokeService, but this service is not checking that the membership is part of any organization (Membership.find_by)Description
This PR refactors the service to use the common
callpattern.It also update the mutation to require an Organization and lookup for the membership with a scope to the current organization.