Fix: closed invoices with generated number #2646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
Before we were setting invoice status to
finalized
ordraft
before calculating fees (because before calculating fees we don't know if it will be 0-invoice or no, and as result we don't know if it will be:finalized
or:closed
)but inside calculate_fees_service we save the invoice, so if it's in
finalized
status we would generate number for this invoice, which is not needed forclosed
invoicesas result we should set invoice to
finalized
or toclosed
after we calculated fees.so the definition if the process is finalization or drafting of the invoice should be done not only by status, but also by the context.
what was done