fix(pdf): Fix credit note generating pdf and webhook

app/services/credit_notes/generate_service.rb

@@ -10,12 +10,11 @@ def initialize(credit_note:, context: nil)
     end
 
     def call
-      return result.not_found_failure!(resource: 'credit_note') if credit_note.blank?
-      return result.not_found_failure!(resource: 'credit_note') unless credit_note.finalized?
+      return result.not_found_failure!(resource: 'credit_note') if credit_note.blank? || !credit_note.finalized?
 
-      generate_pdf(credit_note) if credit_note.file.blank?
+      generate_pdf(credit_note) if should_generate_pdf?
 
-      SendWebhookJob.perform_later('credit_note.generated', credit_note) if should_send_webhook?
+      SendWebhookJob.perform_later('credit_note.generated', credit_note)
 
       result.credit_note = credit_note
       result
@@ -40,8 +39,8 @@ def generate_pdf(credit_note)
       credit_note.save!
     end
 
-    def should_send_webhook?
-      context == 'api'
+    def should_generate_pdf?
+      context == 'admin' || credit_note.file.blank?
     end
   end
 end

spec/services/credit_notes/generate_service_spec.rb

@@ -97,5 +97,15 @@
         end.to have_enqueued_job(SendWebhookJob)
       end
     end
+
+    context 'when context is admin' do
+      let(:context) { 'admin' }
+
+      it 'calls the SendWebhook job' do
+        expect do
+          credit_note_generate_service.call
+        end.to have_enqueued_job(SendWebhookJob)
+      end
+    end
   end
 end