Skip to content

Commit

Permalink
Upgrade gauge ts and chrome version (#2730)
Browse files Browse the repository at this point in the history
* Upgrade gauge ts and chrome

Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
  • Loading branch information
zabil authored Jul 17, 2024
1 parent b4b6fbc commit 7a4f1a8
Show file tree
Hide file tree
Showing 9 changed files with 2,538 additions and 5,446 deletions.
22 changes: 10 additions & 12 deletions .github/workflows/taiko.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ jobs:
node_version: ['20']
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use NodeJS ${{ matrix.node_version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}
- name: install
Expand Down Expand Up @@ -51,14 +51,12 @@ jobs:
strategy:
matrix:
node_version: ['20']
os: [ubuntu-latest]
include:
- os: windows-latest
node_version: '16'
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use NodeJS ${{ matrix.node_version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}
- name: install browser dependencies
Expand Down Expand Up @@ -99,9 +97,9 @@ jobs:
name: FT in linux-headful
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use NodeJS 20
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: 20
- name: install browser dependencies
Expand Down Expand Up @@ -144,9 +142,9 @@ jobs:
name: Docs tests - ${{ matrix.os }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Use NodeJS 20
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: '20'
- name: install
Expand Down
2 changes: 1 addition & 1 deletion lib/actions/pageActionChecks.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ const waitAndGetActionableElement = async (selector, force, checks = defaultChec
actionableElement = elements[0];
return;
}
if (elementsLength !== elements.length) {
if (elements && elementsLength !== elements.length) {
throw Error('Found too many matches. Please use a selector that is more specific');
}
throw new Error(`${description(selector)}${error}`);
Expand Down
Loading

0 comments on commit 7a4f1a8

Please sign in to comment.