This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
style: add theme support #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Jul 1, 2024
rolznz
reviewed
Jul 1, 2024
|
dropdown placement / size does not look so good. Maybe @reneaaron can do his magic 🪄 |
rolznz
reviewed
Jul 1, 2024
reneaaron
reviewed
Jul 1, 2024
|
I fixed the settings layout and generally like the themes, however since we introduced some special variables (warnings, success, etc) and the generated themes do not include these variables I was thinking to reduce the amount of themes available and polish the ones we provide by adding proper values for these variables as well. |
|
Also can add a card somewhere in the UI to tell the user how to set themes (and in README as well) |
this adds themes using different base variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds themes using different base variables..
Note: I don't know what I am doing