Fix ZapPlanner Subscription Budget Calculation and Interval Enforcement (Fixes #60) #61
Conversation
| // Calculate the number of satoshis based on the desired interval | ||
| const satoshis = getSatoshisForInterval(selectedInterval); | ||
|
|
||
| data.amount = satoshis; |
There was a problem hiding this comment.
Hi, this is incorrect. We need to pass a max_amount field to https://github.com/getAlby/nostr-wallet-connect based on the amount and interval the user sets in ZapPlanner, not change the amount for the subscription. Please see the original ticket: #60
| const selectedInterval = data.sleepDuration; | ||
|
|
||
| // Enforce that the interval should not be more than 1 year (365 days) | ||
| if (selectedInterval === "yearly") { |
There was a problem hiding this comment.
please use the duration in milliseconds. Otherwise this will let through e.g. 100 weeks or 1000000000 hours
|
I have implemented the changes , do let me know if there are any further issues |
|
I'm sorry, but this PR does not address the issue ticket, and your updates do not fix the bugs I already mentioned. Your changes do not at all integrate with the NWC budget system. |
|
I hope the changes made now should have fixed the bug. |
|
I will close this PR. I'm sorry but it does not in any way address the issue. In order to complete this task you need to create an Alby account and use Nostr Wallet Connect so you understand what the budgets mean and why we would want to add them here. |
This PR addresses the issue where the ZapPlanner subscription form did not correctly calculate the budget amount based on the selected interval. Additionally, it enforces a limitation on the subscription interval, ensuring it does not exceed one year. The changes made to the ConfirmSubscriptionForm component resolve these issues, improving the user experience when creating subscriptions.
Key Changes:
This PR fixes issue #60 and improves the overall functionality of the ZapPlanner subscription creation process.