Refactor to KMP #12
Draft
Refactor to KMP #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosa91
reviewed
Aug 26, 2024
Comment on lines
-84
to
+91
| Log.e( | ||
| "OuroborosEffects", | ||
| "Error occured in Ouroboros Effect", | ||
| it | ||
| ) | ||
| println("OuroborosEffect - Error occured in Ouroboros Effect: $it") |
There was a problem hiding this comment.
Are we sure about that (changing Log to print)?
There was a problem hiding this comment.
Log only works on android, it won't work on iOS or web
There was a problem hiding this comment.
But so do ViewModel and a lot of stuff, so there is a long way ahead
chosa91
reviewed
Aug 26, 2024
Co-authored-by: Jozsef Csaszi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.