Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Discussion: Adding functionality to allow mutating an iterator of coordinates in place #105

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phayes
Copy link

@phayes phayes commented Feb 4, 2022

Pursuant to the discussion here (georust/geo#718) , I've been playing with the idea of converting / projecting Iterators of mutable coordinates.

This should allow us to convert large geometries with a single-call to Proj.

If folks are amenable to this approach, I'll work on implementing Iterator<Item = &'a mut Coord<CoordinateType>> for geo-types.

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! 👏🏻

@phayes
Copy link
Author

phayes commented Feb 5, 2022

Thanks @frewsxcv ,

Let's not merge it just yet. I've been working on the other side of the problem (having geometries generate an iterator that yield mutable references to coordinates) and have run into some major lifetime issues that might be insurmountable without either GATs or unsafe. I'll post more about that once I have it more clear in my mind.

@phayes phayes marked this pull request as draft February 5, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants