Implement TryFrom<geo_types::Geometry> for GEOS Geometry #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and also TryFrom<geo_types::GeometryCollection>
src/from_geo.rs
Outdated
Comment on lines
241
to
243
| Geometry::Triangle(_) => unimplemented!("Cannot convert Triange to GEOS Geometry"), | ||
| Geometry::Rect(_) => unimplemented!("Cannot convert Rect to GEOS Geometry"), | ||
| Geometry::Line(_) => unimplemented!("Cannot convert Line to GEOS Geometry"), |
There was a problem hiding this comment.
Please return an Err instead of panicking. TryFrom is meant for that.
There was a problem hiding this comment.
Whoops, good point, thanks. Fixed.
GuillaumeGomez
approved these changes
Aug 20, 2024
|
Weird, it seems like building libgeos in the CI is not working anymore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and also TryFrom<geo_types::GeometryCollection>
I noticed that these two trait implementations were missing, and they seemed like they'd be useful inclusions. Each is sort of necessary to implement the other: a
Geometrycan wrap aGeometryCollection, and aGeometryCollectionis made up ofGeometrys (in order to wrap the heterogeneous members in a uniform type). The unit test I added exercises both conversions.Feedback is very welcome.