Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isNull args as a list #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ariana-B
Copy link

@Ariana-B Ariana-B commented Mar 28, 2024

Resolves #91

Accepts isNull args as both arrays and objects for consistency with not implementation. However it's worth noting that the comment regarding the standard being ambiguous might be outdated as the standard seems relatively clear to me:

notExpression:
      type: object
      required:
        - op
        - args
      properties:
        op:
          type: string
          enum:
            - not
        args:
          type: array
          minItems: 1
          maxItems: 1
          items:
            $ref: '#/components/schemas/booleanExpression'

Likewise:

isNullPredicate:
      type: object
      required:
        - op
        - args
      properties:
        op:
          type: string
          enum:
            - isNull
        args:
          $ref: '#/components/schemas/isNullOperand'
    isNullOperand:
      type: array
      minItems: 1
      maxItems: 1
      items:
        oneOf:
          - $ref: '#/components/schemas/characterExpression'
          - $ref: '#/components/schemas/numericExpression'
          - $ref: '#/components/schemas/temporalExpression'
          - $ref: '#/components/schemas/booleanExpression'
          - $ref: '#/components/schemas/geomExpression'

@Ariana-B
Copy link
Author

Ariana-B commented Apr 9, 2024

@constantinius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_cql2 incorrectly formats isNull args
1 participant