Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map): Add attributions (OSM and Carto) #890

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR adds the attributions for the map (OSM and Carto).

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Copy link
Contributor

github-actions bot commented May 29, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, ui-elements, feature-notifications, feature-catalog, feature-search, feature-editor, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@Angi-Kinas
Copy link
Collaborator Author

Thank you @jahow for your help to resolve this issue!

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Note that we might need at some point to allow custom layers from the app config to also have an attributions text. I've created this issue to track this tech debt: #891

Copy link
Contributor

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented May 29, 2024

Coverage Status

coverage: 84.26% (-2.0%) from 86.28%
when pulling 006e607 on fix-OSM-attribution
into 549700b on main.

'isActiveUserEditor' from story
@Angi-Kinas Angi-Kinas merged commit 16f429a into main May 29, 2024
9 checks passed
@Angi-Kinas Angi-Kinas deleted the fix-OSM-attribution branch May 29, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants