Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: fix untranslated text and wrong search filters in organizations page #1016

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 15, 2024

Description

The search filters for the org's datasets were not correctly updated when an organization was opened a second time.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Affected libs: ui-elements, feature-notifications, feature-search, feature-router, feature-map, feature-dataviz, feature-record, feature-editor, feature-catalog, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, datafeeder, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Oct 15, 2024

Coverage Status

coverage: 83.391% (-0.04%) from 83.434%
when pulling e5f6507 on fix-orgs-page
into 822d2a4 on main.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

📷 Screenshots are here!

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing/reworking this @jahow ! Code LGTM and organization page works fine.

I'm just wondering if the case that an organization has no dataset (which shouldn't occur that much in reality, I guess) also works. When creating the ticket, I had the impression there was an issue with the orgHasNoDataset else, but maybe it was related to the change detection you just fixed.

@jahow
Copy link
Collaborator Author

jahow commented Oct 15, 2024

Hmm, actually that should never happen since organizations are taken from the search results. Maybe if we use groups instead, I'll give it a try.

@jahow
Copy link
Collaborator Author

jahow commented Oct 17, 2024

Thanks for fixing/reworking this @jahow ! Code LGTM and organization page works fine.

I'm just wondering if the case that an organization has no dataset (which shouldn't occur that much in reality, I guess) also works. When creating the ticket, I had the impression there was an issue with the orgHasNoDataset else, but maybe it was related to the change detection you just fixed.

Confirmed, an organization should never have zero datasets (otherwise it won't show in the datahub). I simplified the code as a result :)

@jahow jahow merged commit f49deb9 into main Oct 17, 2024
13 checks passed
@jahow jahow deleted the fix-orgs-page branch October 17, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants